Page MenuHomeFreeBSD

include: put includes into -dev packages
ClosedPublic

Authored by kevans on Nov 3 2022, 7:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:51 AM
Unknown Object (File)
Wed, Nov 6, 8:40 PM
Unknown Object (File)
Wed, Nov 6, 1:59 PM
Unknown Object (File)
Thu, Oct 31, 4:44 PM
Unknown Object (File)
Thu, Oct 24, 9:31 PM
Unknown Object (File)
Thu, Oct 24, 8:52 PM
Unknown Object (File)
Thu, Oct 24, 8:52 PM
Unknown Object (File)
Thu, Oct 24, 8:52 PM
Subscribers

Details

Summary

The includes build is kind of funky, as we support either copying or
symlinking files into /usr/include. For copies, we were supplying
the include/ ${TAG_ARGS}, which puts packages into FreeBSD-runtime,
without any consideration to the fact that we're installing headers.

Let's copy the approach that the symlinks target uses for now, and
add ",dev" to the TAG_ARGS so that headers at least end up in
FreeBSD-runtime-dev, which is more appropriate. Some of these includes
are actually technically supposed to be in *other* packages and their
INCSGROUP's PACKAGE setting is actually correct, but this is less
trivial to solve. This is a bandaid to fix the immediate problem of
some headers ending up in two different packages.

PR: 267526

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Nov 3 2022, 7:29 PM

I think that we need a FreeBSD-kernel-headers and put everyone of those includes in this package tbh.
But if it's easier to fix the if_wg problem for now I'm fine with this as a bandaid solution (haven't had time to update my tree past wg yet).

This revision is now accepted and ready to land.Nov 3 2022, 7:56 PM
dfr added a subscriber: dfr.

Looks good to me.

This revision was automatically updated to reflect the committed changes.