Page MenuHomeFreeBSD
Differential D37212

graphics/png: exclude SIMD from armv{6,7} in QEMU_EMULATING
ClosedPublic
Actions

Authored by vishwin on Oct 30 2022, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 9:08 AM
Unknown Object (File)
Mon, Jan 13, 10:50 AM
Unknown Object (File)
Mon, Jan 13, 2:26 AM
Unknown Object (File)
Jan 6 2025, 4:06 PM
Unknown Object (File)
Jan 6 2025, 4:01 PM
Unknown Object (File)
Nov 17 2024, 5:09 PM
Unknown Object (File)
Oct 24 2024, 5:57 PM
Unknown Object (File)
Oct 21 2024, 5:05 PM
View All 72 Files
Subscribers
mat
mikael

Details

Reviewers
tcberner
fluffy
arrowd
Commits
R11:58dd53fbd1be: graphics/png: exclude SIMD from armv{6,7} in QEMU_EMULATING
Summary

The current version added an assert for ARM NEON detection, which is not supported under QEMU_EMULATING, so the build fails. Prevent exposing the SIMD option in this case.

Test Plan

No functional changes.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48091
Build 44978: arc lint + arc unit

Event Timeline

vishwin created this revision.Oct 30 2022, 12:19 AM
Herald added a subscriber: mat. · View Herald TranscriptOct 30 2022, 12:19 AM
vishwin requested review of this revision.Oct 30 2022, 12:19 AM
Harbormaster completed remote builds in B48091: Diff 112392.Oct 30 2022, 12:19 AM
tcberner accepted this revision.Oct 30 2022, 6:54 AM

LGTM

This revision is now accepted and ready to land.Oct 30 2022, 6:54 AM
Closed by commit R11:58dd53fbd1be: graphics/png: exclude SIMD from armv{6,7} in QEMU_EMULATING (authored by vishwin). · Explain WhyOct 31 2022, 2:33 AM
This revision was automatically updated to reflect the committed changes.
vishwin added a commit: R11:58dd53fbd1be: graphics/png: exclude SIMD from armv{6,7} in QEMU_EMULATING.
mikael added a subscriber: mikael.Oct 31 2022, 8:30 AM

what does it have to do with qemu?

vishwin added a comment.Oct 31 2022, 1:57 PM
This comment was removed by vishwin.
vishwin added a comment.Oct 31 2022, 1:58 PM

Don't have any real armv{6,7} hardware I can run compiles on to verify whether the SIMD option works or not, so I left the option exposed for those cases.

Revision Contents
Changeset List

PathSize
graphics/
png/
5 lines

Diff 112392

View Options

graphics/png/Makefile

Loading...