Differential D36923

igc: remove unnecessary PHY ID checks
ClosedPublic
Actions

Authored by kbowling on Oct 10 2022, 6:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 24, 3:00 AM

	Unknown Object (File)
	Oct 16 2024, 1:23 AM

	Unknown Object (File)
	Oct 16 2024, 1:13 AM

	Unknown Object (File)
	Oct 16 2024, 12:10 AM

	Unknown Object (File)
	Sep 16 2024, 5:14 AM

	Unknown Object (File)
	Sep 12 2024, 3:19 PM

	Unknown Object (File)
	Sep 8 2024, 8:45 PM

	Unknown Object (File)
	Sep 8 2024, 3:44 AM

View All 50 Files

Subscribers

Details

Reviewers

Commits

rG61b2374e0c05: igc: remove unnecessary PHY ID checks
rGf2a0b610b840: igc: remove unnecessary PHY ID checks
rG29d7f1ff5795: igc: remove unnecessary PHY ID checks

Summary

net/igc: remove unnecessary PHY ID checks

I225 devices have only one PHY vendor. There is unnecessary to check
_I_PHY_ID during the link establishment and auto-negotiation process,
the checking also caused devices like i225-IT failed. This patch is to
remove the mentioned unnecessary checking.

Cc: stable@dpdk.org

Signed-off-by: Mah Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Taripin Samuel <samuel.taripin@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Oct 10 2022, 6:39 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 10 2022, 6:39 AM

kbowling requested review of this revision.Oct 10 2022, 6:39 AM

grehan accepted this revision.Oct 10 2022, 7:54 AM

This revision is now accepted and ready to land.Oct 10 2022, 7:54 AM

Closed by commit rG29d7f1ff5795: igc: remove unnecessary PHY ID checks (authored by Mah Yock Gen <yock.gen.mah@intel.com>, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyOct 10 2022, 8:52 AM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG29d7f1ff5795: igc: remove unnecessary PHY ID checks.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGf2a0b610b840: igc: remove unnecessary PHY ID checks.Oct 17 2022, 3:37 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG61b2374e0c05: igc: remove unnecessary PHY ID checks.

Revision Contents
Changeset List

Path

Size

sys/

dev/

igc/

11 lines

6 lines

Diff 111605

sys/dev/igc/igc_i225.c

Loading...

sys/dev/igc/igc_phy.c

Loading...