Page MenuHomeFreeBSD

bus.h: rewrite comment describing intr_type
ClosedPublic

Authored by mhorne on Oct 6 2022, 6:57 PM.
Tags
None
Referenced Files
F102876828: D36896.id111518.diff
Mon, Nov 18, 8:09 AM
F102874292: D36896.id111573.diff
Mon, Nov 18, 7:19 AM
Unknown Object (File)
Sep 30 2024, 10:34 AM
Unknown Object (File)
Sep 11 2024, 2:22 AM
Unknown Object (File)
Sep 5 2024, 1:05 AM
Unknown Object (File)
Aug 25 2024, 7:28 PM
Unknown Object (File)
Aug 9 2024, 10:03 PM
Unknown Object (File)
Aug 5 2024, 7:03 AM
Subscribers

Details

Summary

Describe more clearly the purpose of these flags and where they are
used.

Remove grog's comment about revisiting the flags. At this point it does
not make sense to change this long-standing API, especially in light of
2cf7870864ea ("Collapse interrupt thread priorities").

Give a better example of a bus modifying these flags; I did not find any
existing instance where a bus changes the interrupt's type.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Oct 6 2022, 6:57 PM
markj added inline comments.
sys/sys/bus.h
267

"will attempt to apply" sounds a bit strange to me, maybe "may apply"?

This revision is now accepted and ready to land.Oct 6 2022, 7:45 PM

I like mark's suggestion, but otherwise I think this is good. At first it was a bit of a squishy concept what this would mean, and in the end it's been used as an indirect way to give each of these interrupts a different priority level. We have some local hacks to adjust relative priorities based on the interrupt type relative to upstream as well, though I don't think that belongs here since it is a layer or two removed.

tl;dr: I think the new comments capture the state of things well and are a big improvement.

sys/sys/bus.h
267

Sure thing.

This revision was automatically updated to reflect the committed changes.