PR: 261711
Details
Details
- Reviewers
kp - Group Reviewers
network - Commits
- rGa9c3d5de9ac8: if_vxlan(4): Check the size of data available in mbuf before using them
rG639aebb2aa0b: if_vxlan(4): Check the size of data available in mbuf before using them
rG0156c3f1f760: if_vxlan(4): Check the size of data available in mbuf before using them
rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/net/if_vxlan.c | ||
---|---|---|
2852 | Check it lazily may be better, i.e. after checking if running status. |
Comment Actions
This looks sane to me. We really do have to make sure there's enough contiguous data before we access it.
sys/net/if_vxlan.c | ||
---|---|---|
2852 | I'm not sure it's worth having this check. m_pullup() simply won't do anything if the mbuf already has sufficient contiguous space. |
sys/net/if_vxlan.c | ||
---|---|---|
2852 | VXLAN over wireguard or some other setups that have deeper tunnels should be rare. |