Page MenuHomeFreeBSD
Differential D36479

graphics/drm-kmod: Fix dependency on firmwares
ClosedPublic
Actions

Authored by zirias on Sep 7 2022, 11:28 AM.
Tags
None
Referenced Files
F108023905: D36479.diff
Mon, Jan 20, 3:49 PM
Unknown Object (File)
Sat, Jan 18, 9:52 PM
Unknown Object (File)
Sat, Jan 18, 9:16 PM
Unknown Object (File)
Dec 13 2024, 3:38 PM
Unknown Object (File)
Dec 11 2024, 11:46 PM
Unknown Object (File)
Nov 28 2024, 10:40 AM
Unknown Object (File)
Nov 28 2024, 10:40 AM
Unknown Object (File)
Nov 28 2024, 10:40 AM
View All 96 Files
Subscribers
mat

Details

Reviewers
tcberner
manu
Group Reviewers
x11
Commits
R11:1226fa26de03: graphics/drm-kmod: Fix dependency on firmwares
R11:307502b65277: graphics/drm-kmod: Fix dependency on firmwares
Summary

Don't overwrite RUN_DEPENDS, add to it.

While here, indent .if/.elif/.endif correctly.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47281
Build 44168: arc lint + arc unit

Event Timeline

zirias created this revision.Sep 7 2022, 11:28 AM
Herald added a subscriber: mat. · View Herald TranscriptSep 7 2022, 11:28 AM
zirias requested review of this revision.Sep 7 2022, 11:28 AM
Harbormaster completed remote builds in B47279: Diff 110258.Sep 7 2022, 11:28 AM
tcberner added a reviewer: manu.Sep 7 2022, 11:31 AM
zirias updated this revision to Diff 110259.Sep 7 2022, 11:49 AM

Also allow all architectures supported by the concrete drm package. If not supported, fail instead of depending on just firmwares.

Harbormaster completed remote builds in B47280: Diff 110259.Sep 7 2022, 11:49 AM
manu accepted this revision.Sep 7 2022, 11:57 AM
This revision is now accepted and ready to land.Sep 7 2022, 11:57 AM
tcberner requested changes to this revision.Sep 7 2022, 12:07 PM
tcberner added inline comments.
graphics/drm-kmod/Makefile
24

^ you need to define _DRM_ARCHS in the .else case too, for the :M to wokr below

This revision now requires changes to proceed.Sep 7 2022, 12:07 PM
zirias updated this revision to Diff 110261.Sep 7 2022, 12:10 PM

Fix make error on 13.0 by always defining _DRM_ARCHS

Harbormaster completed remote builds in B47281: Diff 110261.Sep 7 2022, 12:10 PM
manu accepted this revision.Sep 7 2022, 12:12 PM
manu added inline comments.
graphics/drm-kmod/Makefile
24

That's not supposed to happened in supported release but yeah :)

tcberner accepted this revision.Sep 7 2022, 12:16 PM

Macro ssshipit:

This revision is now accepted and ready to land.Sep 7 2022, 12:16 PM
Closed by commit R11:307502b65277: graphics/drm-kmod: Fix dependency on firmwares (authored by zirias). · Explain WhySep 7 2022, 12:17 PM
This revision was automatically updated to reflect the committed changes.
zirias added a commit: R11:307502b65277: graphics/drm-kmod: Fix dependency on firmwares.
zirias added a commit: R11:1226fa26de03: graphics/drm-kmod: Fix dependency on firmwares.Sep 7 2022, 12:37 PM

Revision Contents
Changeset List

PathSize
graphics/
drm-kmod/
20 lines

Diff 110261

View Options

graphics/drm-kmod/Makefile

Loading...