Page MenuHomeFreeBSD

raw ip: fix regression with multicast and RSVP
ClosedPublic

Authored by glebius on Sep 2 2022, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 10, 10:01 PM
Unknown Object (File)
Sep 22 2024, 9:52 PM
Unknown Object (File)
Sep 22 2024, 9:52 PM
Unknown Object (File)
Sep 22 2024, 9:52 PM
Unknown Object (File)
Sep 22 2024, 9:52 PM
Unknown Object (File)
Sep 22 2024, 9:42 PM
Unknown Object (File)
Sep 15 2024, 12:44 PM
Unknown Object (File)
Sep 14 2024, 9:44 PM
Subscribers

Details

Summary

With 61f7427f02a raw sockets protosw has wildcard pr_protocol. Protocol
of a specific pcb is stored in inp_ip_p.

Reported by: karels
Fixes: 61f7427f02a307d28af674a12c45dd546e3898e4

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good as far as it goes. I think ip6_mroute and probably others have similar problems. rsvp does.

glebius retitled this revision from mroute: fix regression with MRT_INIT to raw ip: fix regression with multicast and RSVP.Sep 2 2022, 6:23 PM

See also a couple of uses of pr_protocol in ip6_output.c (ICMPv6).

Ok, I think I found them all. Sorry for breakage :(

Everything that the regression test suite catches was included
in the 61f7427f02a307d28af674a12c45dd546e3898e4.

LGTM; I think this covers everything that my survey of pr_protocol use found.

This revision is now accepted and ready to land.Sep 2 2022, 7:09 PM