x11/xscreensaver: Remove PAM option
ClosedPublic
Actions

Authored by zirias on Sep 2 2022, 6:20 AM.

Details

Reviewers

tcberner
manu
cy

Group Reviewers

x11

Commits

R11:ecc6daf598b2: x11/xscreensaver: Remove PAM option

Summary

Upstream ./configure now fails with --without-pam if PAM is found on the
build system with this message:

Your system seems to have PAM, but PAM is not being used.
That is probably not going to work out well.

We have PAM in base and can't build base without it any more
(WITHOUT_PAM is deprecated), so let's just remove that port option and
always build xscreensaver with PAM (previously enabled by default).

PR: 264361

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 47230
Build 44117: arc lint + arc unit

Event Timeline

zirias created this revision.Sep 2 2022, 6:20 AM

Herald added a subscriber: mat. · View Herald TranscriptSep 2 2022, 6:20 AM

zirias requested review of this revision.Sep 2 2022, 6:20 AM

Harbormaster completed remote builds in B47229: Diff 110072.Sep 2 2022, 6:20 AM

tcberner requested changes to this revision.Sep 2 2022, 7:17 AM

tcberner added inline comments.

x11/xscreensaver/Makefile
2–3	^ `PORTREVISON=1`

This revision now requires changes to proceed.Sep 2 2022, 7:17 AM

Bump PORTREVISION. While not strictly necessary (PAM was enabled and disabling it broke the build), it documents a relevant change and fixes pkg metadata.

Harbormaster completed remote builds in B47230: Diff 110073.Sep 2 2022, 7:31 AM

zirias marked an inline comment as done.Sep 2 2022, 7:32 AM

tcberner accepted this revision.Sep 2 2022, 7:42 AM

This revision is now accepted and ready to land.Sep 2 2022, 7:42 AM

With PAM enforced, support for shadow passwords is not needed. Forcing
it to off, we can avoid installing xscreensaver-auth suid root.

This revision now requires review to proceed.Sep 2 2022, 9:13 AM

Harbormaster completed remote builds in B47231: Diff 110074.Sep 2 2022, 9:13 AM

manu accepted this revision.Sep 2 2022, 4:12 PM

This revision is now accepted and ready to land.Sep 2 2022, 4:12 PM