Details
Details
- Reviewers
- None
- Group Reviewers
manpages
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I'm not sure I understand the driver changes this is meant to document. Someone else will have to check for consistency with that. Perhaps the reviewer(s) for these changes. Meanwhile, could you upload a full diff next time as already requested in one of these reviews?
share/man/man4/cgem.4 | ||
---|---|---|
110 | s/RGMII,/RGMII;/ (comma splice) | |
111 | s/in device tree/in the device tree/ |
share/man/man4/cgem.4 | ||
---|---|---|
54 | While here, you could tweak this to mention the HiFive Unmatched instead. It is a more relevant example. | |
111–113 | IMO, device tree properties are beyond the scope of what we would expect in a driver man page. I think it is enough to say the following: The .Nm driver supports GMII, RGMII, and SGMII PHY connection modes. |