Page MenuHomeFreeBSD
Differential D35942

linuxkpi: Add io.h
ClosedPublic
Actions

Authored by manu on Jul 26 2022, 9:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 11 2024, 7:43 AM
Unknown Object (File)
Oct 3 2024, 12:53 AM
Unknown Object (File)
Oct 2 2024, 10:25 PM
Unknown Object (File)
Sep 18 2024, 6:53 PM
Unknown Object (File)
Sep 18 2024, 4:54 PM
Unknown Object (File)
Sep 18 2024, 12:01 PM
Unknown Object (File)
Sep 18 2024, 10:09 AM
Unknown Object (File)
Sep 17 2024, 2:50 PM
View All 43 Files
Subscribers
bz
emaste
• hselasky
imp
linuxkpi

Details

Reviewers
None
Group Reviewers
linuxkpi
Commits
rG96c30348bda0: linuxkpi: Add io.h
rG96b917bfcf2c: linuxkpi: Add io.h
Summary

out* arguments are different on Linux and the i915 driver uses them.
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Jul 26 2022, 9:32 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJul 26 2022, 9:32 AM
manu requested review of this revision.Jul 26 2022, 9:32 AM
Harbormaster completed remote builds in B46589: Diff 108543.Jul 26 2022, 9:32 AM
manu added a reviewer: linuxkpi.Jul 26 2022, 9:34 AM
• hselasky added a subscriber: • hselasky.Jul 26 2022, 9:50 AM

This looks pretty scary. Can you make sure that this file includes the file defining outb() and outw() and outl() first?

And that this file is not included anywhere else?

--HPS

bz added a subscriber: bz.Jul 28 2022, 10:06 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/asm-generic/io.h
30

Do we need to put all, including the #include into ... given we don't do per-arch asm/?
#if defined(i386) || defined(amd64)

#include <machine/cpufunc.h> /* and possibly other dependencies? */

...
#endif

manu updated this revision to Diff 108797.Aug 2 2022, 7:41 AM

Only add this for x86

Harbormaster completed remote builds in B46709: Diff 108797.Aug 2 2022, 7:41 AM
manu updated this revision to Diff 108800.Aug 2 2022, 8:01 AM

Fix by using correct names for the arches.

Harbormaster completed remote builds in B46712: Diff 108800.Aug 2 2022, 8:01 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2022, 2:06 PM
Closed by commit rG96b917bfcf2c: linuxkpi: Add io.h (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG96b917bfcf2c: linuxkpi: Add io.h.
manu added a commit: rG96c30348bda0: linuxkpi: Add io.h.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
asm-generic/
40 lines

Diff 108991

View Options

sys/compat/linuxkpi/common/include/asm-generic/io.h

Loading...