rc.subr: Make sure oomprotect protects existing children

[0mp]

Summary

The rc(8) framework support protecting services from OOM killer.
The current implementation applies the protection after the service has
already started. This works fine if only the main process is to be
protected (*_oomprotect=yes). However, the current implementation fails
to protect existing children when children are also to be protected
(*_oomprotect=all). This patch fixes that.

Note: it is not easy to apply the protectoin earlier because we want to
support both the services which use the "command" variable and those
that use the "start_cmd" variable.

PR: 256148
Co-authored-by: Mike Walker <[e-mail]>
Tested by: Jamie Landeg-Jones <[e-mail]>
Fixes: 3bead71e959d - Add a global option where we can protect
MFC after: 1 week

Test Plan

The tests are implemented here: https://reviews.freebsd.org/D35745

[adrian]

hey nice catch!

[oshogbo]

The change LGTM.
That said I would suggest committing this as submited by: Mike Walker, not as a co-authored as he did the heavy lifting in this change.