ipmi: handle ipmb requests

[yuri_aetern.org]

Summary

Handle IPMB requests using SEND_MSG (sent as driver request as we do not need to return anything back to userland for this) and GET_MSG (sent as usual request so we can return the data for RECEIVE_MSG ioctl) pair.

Test Plan

Tested using ipmitool on HPE ProLiant DL380 Gen10 now properly showing all of the sensors.

[yuri_aetern.org]

sys/dev/ipmi/ipmi.c

388

this removal is likely unrelated and could be done separately, just a note that we are using the ipmi driver in illumos ported from FreeBSD with this part removed for *years*, so the more wide testing of this change is based on the assumption that this is removed

[philip]

I've tested this on a DL380 and can confirm it works.

I don't like the #if 0 bit. Other than that, I think this can be committed.

(I don't like the mix of u_char and uint8_t in this driver either, but that's a separate issue.)

sys/dev/ipmi/ipmi.c

251–252

Just delete it instead of #if 0 bracketing it. If we need to resurrect this code, we can get it back from Git.

[yuri_aetern.org]

removed the ifdef 0'ed code

[vangyzen]

sys/dev/ipmi/ipmi.c

393

This uses kreq after freeing it. Coverity CID 1490456

[philip]

sys/dev/ipmi/ipmi.c

393

Good catch! Thanks. I'll commit this fix.

[yuri_aetern.org]

My bad, thanks for fixing this.