Page MenuHomeFreeBSD

bhyve nvme: Check return value of mapped memory
ClosedPublic

Authored by chuck on Jun 10 2022, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 9:25 PM
Unknown Object (File)
Sat, Jan 4, 11:51 PM
Unknown Object (File)
Dec 5 2024, 9:58 AM
Unknown Object (File)
Oct 1 2024, 1:15 PM
Unknown Object (File)
Sep 28 2024, 11:07 AM
Unknown Object (File)
Sep 28 2024, 7:36 AM
Unknown Object (File)
Sep 24 2024, 11:30 PM
Unknown Object (File)
Sep 24 2024, 5:11 AM
Subscribers

Details

Summary

Fuzzing of bhyve using hyfuzz discovered a way to cause a segmentation
fault in the NVMe emulation. If a guest specifies a physical address in
either the PRP1 or PRP2 field of a command that cannot be mapped from
guest to host, the function paddr_guest2host() returns a NULL pointer.
The NVMe emulation did not check for this error case, which allowed for
the segmentation fault to occur.

Fix is to check for a return value of NULL and indicate an error back to
the guest (Data Transfer error). While in the area, slightly refactor
the write/read blockif function to use a common error exit path.

PR: 256321
Reported by: Cheolwoo Myung <cwmyung@snu.ac.kr>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable