Use KERNEL_PANICKED() in more places

[mhorne]

Summary

This is slightly more optimized than checking panicstr directly. For
most of these instances performance doesn't matter, but let's make
KERNEL_PANICKED() the common idiom.

[imp]

sys/kern/subr_asan.c

390

So you didn't preserve the __predict_false here... but...

sys/kern/subr_msan.c

181

.... but you did here. Is there a reason for the difference?

[mjg]

sys/kern/subr_msan.c

181

the latter is a part of a bigger statement

i would argue the KERNEL_PANICKED || kdb_active thing should also be short-circuited into one macro which performs one branch

[mhorne]

sys/kern/subr_asan.c

390

It is not obvious from this review, but KERNEL_PANICKED() expands to __predict_false(panicked).

[imp]

sys/kern/subr_asan.c

390

Yea, I was wondering about the difference treatment... Though I misread the parens in at least one place.