Page MenuHomeFreeBSD
Differential D35071

Committers-guide port section: remove addport
ClosedPublic
Actions

Authored by pizzamig on Apr 26 2022, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 9:49 PM
Unknown Object (File)
Mon, Nov 4, 5:56 PM
Unknown Object (File)
Oct 6 2024, 8:04 AM
Unknown Object (File)
Sep 30 2024, 9:41 AM
Unknown Object (File)
Sep 30 2024, 9:41 AM
Unknown Object (File)
Sep 30 2024, 9:41 AM
Unknown Object (File)
Sep 30 2024, 9:40 AM
Unknown Object (File)
Sep 30 2024, 9:40 AM
View All Files
Subscribers
0mp
pauamma_gundo.com

Details

Reviewers
tcberner
se
rene
pauamma_gundo.com
0mp
Group Reviewers
portmgr
Commits
R9:e1f62cbb8da6: Committers-guide port section: remove addport
Summary

The script addport is not working anymore, it's based on SVN and
it's quite hard to port it to git.
Before its removal, we want to remove its references in the
documentation.
Related bugzilla entry:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261378

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45462
Build 42350: arc lint + arc unit

Event Timeline

pizzamig requested review of this revision.Apr 26 2022, 6:37 PM
pizzamig created this revision.
Harbormaster completed remote builds in B45385: Diff 105445.Apr 26 2022, 6:37 PM
pizzamig added reviewers: rene, portmgr.Apr 26 2022, 6:39 PM
tcberner added a comment.Apr 26 2022, 6:40 PM

lgtm

rene accepted this revision.Apr 28 2022, 7:31 AM
This revision is now accepted and ready to land.Apr 28 2022, 7:31 AM
pauamma_gundo.com requested changes to this revision.Apr 28 2022, 7:28 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.
pauamma_gundo.com added inline comments.
documentation/content/en/articles/committers-guide/_index.adoc
3690

https://webaim.org/techniques/hypertext/#alpha_links

This revision now requires changes to proceed.Apr 28 2022, 7:28 PM
rene added a comment.Apr 30 2022, 8:08 PM

See also https://reviews.freebsd.org/D35104 which removes addport itself.

pizzamig updated this revision to Diff 105673.May 4 2022, 2:18 PM

Following up on the comment about screen readers

Harbormaster completed remote builds in B45461: Diff 105673.May 4 2022, 2:18 PM
pizzamig updated this revision to Diff 105674.May 4 2022, 2:20 PM

Remove unwanted changes

Harbormaster completed remote builds in B45462: Diff 105674.May 4 2022, 2:21 PM
pizzamig marked an inline comment as done.May 4 2022, 2:21 PM
pauamma_gundo.com accepted this revision.May 5 2022, 2:34 PM
This revision is now accepted and ready to land.May 5 2022, 2:34 PM
pizzamig updated this revision to Diff 105713.May 5 2022, 7:45 PM

My lack of confidence with arc removed the previous commit

This revision now requires review to proceed.May 5 2022, 7:45 PM
Harbormaster completed remote builds in B45479: Diff 105713.May 5 2022, 7:45 PM
0mp accepted this revision.May 5 2022, 7:55 PM
0mp added a subscriber: 0mp.

Once those minor nits are addressed, it is ready to land.

Approved by: 0mp (doc)

PS Bonus points for avoiding "you" in the documentation. ;)

documentation/content/en/articles/committers-guide/_index.adoc
3674
  1. Please keep one sentence per line.
  2. Use backticks around SUBDIR.
3690

Missing dot at the end.

This revision is now accepted and ready to land.May 5 2022, 7:55 PM
pizzamig updated this revision to Diff 105714.May 5 2022, 8:39 PM
  • Addressing 0mp feedback
This revision now requires review to proceed.May 5 2022, 8:39 PM
Harbormaster completed remote builds in B45480: Diff 105714.May 5 2022, 8:40 PM
pizzamig updated this revision to Diff 105715.May 5 2022, 8:44 PM
pizzamig marked an inline comment as done.
  • Put backticks in the right SUBDIR
Harbormaster completed remote builds in B45481: Diff 105715.May 5 2022, 8:44 PM
pizzamig marked an inline comment as done.May 5 2022, 8:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 9 2022, 9:04 AM
Closed by commit R9:e1f62cbb8da6: Committers-guide port section: remove addport (authored by pizzamig). · Explain Why
This revision was automatically updated to reflect the committed changes.
pizzamig added a commit: R9:e1f62cbb8da6: Committers-guide port section: remove addport.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
articles/
committers-guide/
2 lines

Diff 105674

View Options

documentation/content/en/articles/committers-guide/_index.adoc

Loading...