ASAN: reduce verbosity
ClosedPublic
Actions

Authored by bapt on Apr 25 2022, 9:26 AM.

Details

Reviewers

Commits

rG84f5770003c4: ASAN: reduce verbosity
rG0a736f0a6aeb: ASAN: reduce verbosity

Summary

When running binaries compiled with libasan in PIE and with ALSR on,
the previous code always print the WARNING message, the new code only
printed it if the run is made with the right verbosity

Before this change, many unit test will always fail because of the extra
message which is printed

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Apr 25 2022, 9:26 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2022, 9:26 AM

bapt requested review of this revision.Apr 25 2022, 9:26 AM

Harbormaster completed remote builds in B45357: Diff 105394.Apr 25 2022, 9:26 AM

LGTM except style issue, look at the SANITIZER_PPC64V2 case above, space after the 1 and line up the string indentation.

This revision is now accepted and ready to land.Apr 25 2022, 1:37 PM

Closed by commit rG0a736f0a6aeb: ASAN: reduce verbosity (authored by bapt). · Explain WhyApr 25 2022, 1:42 PM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG0a736f0a6aeb: ASAN: reduce verbosity.

Note to self: for upstreaming, see also D33934

dim added a commit: rG84f5770003c4: ASAN: reduce verbosity.May 30 2022, 6:32 PM

Revision Contents
Changeset List

Path

Size

contrib/

llvm-project/

compiler-rt/

lib/

sanitizer_common/

sanitizer_linux.cpp

6 lines

Diff 105398

View Options

contrib/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp

ASAN: reduce verbosityClosedPublicActions