Page MenuHomeFreeBSD

bsddialog(3): fix disabled shadow
ClosedPublic

Authored by asiciliano on Apr 19 2022, 2:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 12:56 PM
Unknown Object (File)
Nov 30 2024, 10:24 PM
Unknown Object (File)
Oct 18 2024, 1:11 PM
Unknown Object (File)
Sep 26 2024, 10:56 AM
Unknown Object (File)
Sep 25 2024, 9:25 PM
Unknown Object (File)
Sep 25 2024, 4:18 PM
Unknown Object (File)
Sep 25 2024, 7:33 AM
Unknown Object (File)
Sep 24 2024, 6:22 PM
Subscribers

Details

Summary

Fix dialogs building and updating segmentation fault with disabled shadow (conf.shadow=false and implicitly bsddialog --no-shadow).
No component in BASE is affected.
Moreover delete WARNS: all warnings were fixed in upstream and imported in 0.2.

Test Plan

Trivial:

-       if (shadow != NULL)
+       if (conf->shadow)

(Probably the error was introduced during the last refactoring to improve the dialogs building process).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asiciliano created this revision.
This revision is now accepted and ready to land.Apr 20 2022, 12:37 PM
This revision was automatically updated to reflect the committed changes.