Page MenuHomeFreeBSD

mld6: Ensure that mld_domifattach() always succeeds
ClosedPublic

Authored by markj on Apr 18 2022, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 1:22 AM
Unknown Object (File)
Mon, Jan 13, 8:41 PM
Unknown Object (File)
Dec 11 2024, 10:03 AM
Unknown Object (File)
Dec 10 2024, 2:31 PM
Unknown Object (File)
Nov 19 2024, 1:43 PM
Unknown Object (File)
Nov 15 2024, 6:33 PM
Unknown Object (File)
Oct 29 2024, 9:23 PM
Unknown Object (File)
Oct 27 2024, 6:47 AM

Details

Summary

mld_domifattach() does a memory allocation under the global MLD mutex,
and so can fail (but no error handling prevents a null pointer
dereference in this case). However, the mutex is only needed when
updating the global softc list; the allocation and static initialization
of the softc does not require this mutex. So, reduce the scope of the
mutex and use M_WAITOK for the allocation.

No functional change intended.

PR: 261457

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Apr 18 2022, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2022, 5:27 PM
This revision was automatically updated to reflect the committed changes.