powerpc cpu_idle_60x: Move some variables fully under #ifdef AIM.
ClosedPublic
Actions

Authored by jhb on Apr 13 2022, 11:05 PM.

Details

Reviewers

jhibbits
bdragon

Commits

rG7c1ff7146b7a: powerpc cpu_idle_60x: Move some variables fully under #ifdef AIM.

Summary

XXX: Is the read from mfmsr required?

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 13 2022, 11:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 13 2022, 11:05 PM

jhb requested review of this revision.Apr 13 2022, 11:05 PM

Harbormaster completed remote builds in B45152: Diff 104978.Apr 13 2022, 11:05 PM

The mfmsr is required, because if you look at line 763/764 it's doing a mtmsr of (msr | PSL_POW). It *could* be replaced with the mfmsr() in each instance of the mtmsr (inline function and the asm), but that's redundant.

This revision is now accepted and ready to land.Apr 14 2022, 12:04 AM

I meant, is it required even in the non-AIM case (such that I would need to keep the mfmsr even for !AIM)? I'm assuming it isn't required for !AIM though based on your approval.

It's not required in the !AIM case. This function won't even get called in the !AIM case. I think at some point we'll need to clean up that file and split the AIM and !AIM into their respective files.

Closed by commit rG7c1ff7146b7a: powerpc cpu_idle_60x: Move some variables fully under #ifdef AIM. (authored by jhb). · Explain WhyApr 18 2022, 7:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7c1ff7146b7a: powerpc cpu_idle_60x: Move some variables fully under #ifdef AIM..