Page MenuHomeFreeBSD
Differential D34882

ping: split the visual part of -f into a new option -.
ClosedPublic
Actions

Authored by pstef on Apr 11 2022, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 6:54 PM
Unknown Object (File)
Tue, Nov 5, 6:42 PM
Unknown Object (File)
Tue, Nov 5, 6:41 PM
Unknown Object (File)
Mon, Nov 4, 8:20 PM
Unknown Object (File)
Oct 1 2024, 12:30 AM
Unknown Object (File)
Oct 1 2024, 12:20 AM
Unknown Object (File)
Oct 1 2024, 12:17 AM
Unknown Object (File)
Sep 21 2024, 1:13 PM
View All 69 Files
Subscribers
imp
pauamma_gundo.com
rpokala

Details

Reviewers
asomers
emaste
kevans
pauamma_gundo.com
Group Reviewers
manpages
Commits
rG149466a516b2: ping: split the visual part of -f into a new option -.
rGd399eb3ef7f8: ping: split the visual part of -f into a new option -.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pstef requested review of this revision.Apr 11 2022, 3:02 PM
pstef created this revision.
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Apr 11 2022, 10:52 PM

Manual page language LGTM.

rpokala added a subscriber: rpokala.Apr 12 2022, 1:11 AM
rpokala added inline comments.
sbin/ping/ping.8
154
sent, a period
158
received, a backspace is printed.
161

You call the default character period elsewhere, but you call it dot here. Pick one and use it consistently. (FWIW, I prefer dot.)

pstef updated this revision to Diff 105062.Apr 15 2022, 8:37 PM

Address comments by rpokala.
I decided to choose the word "period" over "dot" because the former was already here.

pauamma_gundo.com accepted this revision.Apr 17 2022, 4:10 AM

Agree with "period" for consistency.

This revision is now accepted and ready to land.Apr 17 2022, 4:10 AM
Closed by commit rGd399eb3ef7f8: ping: split the visual part of -f into a new option -. (authored by pstef). · Explain WhyApr 18 2022, 5:15 PM
This revision was automatically updated to reflect the committed changes.
pstef added a commit: rGd399eb3ef7f8: ping: split the visual part of -f into a new option -..
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2022, 5:15 PM
pstef added a commit: rG149466a516b2: ping: split the visual part of -f into a new option -..Dec 24 2022, 7:22 AM

Revision Contents
Changeset List

PathSize
sbin/
ping/
4 lines
29 lines
23 lines
21 lines

Diff 105111

View Options

sbin/ping/main.h

Loading...
View Options

sbin/ping/ping.8

Loading...
View Options

sbin/ping/ping.c

Loading...
View Options

sbin/ping/ping6.c

Loading...