Page MenuHomeFreeBSD

ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.
ClosedPublic

Authored by jhb on Apr 7 2022, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 2:13 PM
Unknown Object (File)
Oct 7 2024, 12:04 AM
Unknown Object (File)
Oct 2 2024, 10:47 PM
Unknown Object (File)
Sep 23 2024, 5:13 AM
Unknown Object (File)
Sep 22 2024, 2:04 AM
Unknown Object (File)
Sep 20 2024, 7:49 AM
Unknown Object (File)
Sep 19 2024, 11:56 PM
Unknown Object (File)
Sep 18 2024, 5:31 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 7 2022, 6:02 PM

As noted in the comments, this isn't really the right fix IMO, but more of a prod to figure out what the right fix is.

I'm going to go with just having all of the cpu_id code be axed. I added @krzysztof.galazka_intel.com to see if he has an opinion, but I can't recall or figure out what the cpu_id code is for. I guess it could've remained from an older version of the iflib api; I vaguely remember some softirq argument change where the cpu_id was removed.

jhb retitled this revision from ix: Mark cpu_id as unused. to ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign..Apr 12 2022, 10:21 PM
jhb edited the summary of this revision. (Show Details)
  • Remove cpu_id and related code.

Digging through using git blame, it doesn't look like the cpu_id was ever even used in the first place...

This revision is now accepted and ready to land.Apr 12 2022, 10:42 PM