bnhd: Write out updated resource dependencies from the table.
ClosedPublic
Actions

Authored by jhb on Apr 6 2022, 11:55 PM.

Details

Reviewers

landonf
imp

Commits

rG6dcb516ba69a: bnhd: Write out updated resource dependencies from the table.
rG3cebca152b18: bnhd: Write out updated resource dependencies from the table.

Summary

The driver parsed the table to update the relevant resource map
registers, but failed to write the new register value after computing
it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 6 2022, 11:55 PM

jhb created this revision.

Harbormaster completed remote builds in B45039: Diff 104699.Apr 6 2022, 11:55 PM

This looks good to me. I was going to delete all this code and then realized it was a bug of some flavor and then punted when I looked at it.

imp accepted this revision.Apr 7 2022, 2:15 AM

This revision is now accepted and ready to land.Apr 7 2022, 2:15 AM

Looks good to me, as well. Thank you.

Closed by commit rG3cebca152b18: bnhd: Write out updated resource dependencies from the table. (authored by jhb). · Explain WhyApr 7 2022, 5:47 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3cebca152b18: bnhd: Write out updated resource dependencies from the table..

jhb added a commit: rG6dcb516ba69a: bnhd: Write out updated resource dependencies from the table..May 13 2022, 5:59 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

cores/

pmu/

bhnd_pmu_subr.c

3 lines

Diff 104731

View Options

sys/dev/bhnd/cores/pmu/bhnd_pmu_subr.c

bnhd: Write out updated resource dependencies from the table.ClosedPublicActions