Page MenuHomeFreeBSD

pfsync: Add CTLFLAG_VNET to carp_demotion_factor sysctl
ClosedPublic

Authored by email_luiz.eng.br on Apr 1 2022, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 1:51 AM
Unknown Object (File)
Sep 22 2024, 1:35 PM
Unknown Object (File)
Sep 21 2024, 10:51 PM
Unknown Object (File)
Sep 18 2024, 1:35 PM
Unknown Object (File)
Sep 18 2024, 11:10 AM
Unknown Object (File)
Sep 18 2024, 2:49 AM
Unknown Object (File)
Sep 16 2024, 7:59 PM
Unknown Object (File)
Sep 16 2024, 1:05 PM

Details

Summary

When trying to avoid a CARP demotion during a pfsync service restart, I noticed that a non-default value for the net.pfsync.carp_demotion_factor sysctl was not being applied during the demotion. The CARP was always demoted by 240.

After investigating, I realized that the sysctl was using VNET_NAME() without the CTLFLAG_VNET.

Please inform me if something is wrong or missing with this revision/differential. This is the first time I'm creating one.

PR: 262983
Submitted by: Luiz Amaral <email@luiz.eng.br>

Test Plan

Setup pfsync between two hosts.

Go to one of the hosts and issue:

# sysctl net.pfsync.carp_demotion_factor=0
# service pfsync restart
# grep carp /var/log/messages

Check the grep output and confirm that during the pfsync bulk operation, the CARP was demoted by 0 instead of 240.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable