Page MenuHomeFreeBSD
Differential D34507

added changes for rsc handler
ClosedPublic
Actions

Authored by schakrabarti_microsoft.com on Mar 9 2022, 9:09 AM.
Tags
None
Referenced Files
F102949814: D34507.id103865.diff
Tue, Nov 19, 2:45 AM
Unknown Object (File)
Sun, Nov 10, 2:59 AM
Unknown Object (File)
Fri, Nov 8, 3:18 AM
Unknown Object (File)
Sun, Nov 3, 5:04 PM
Unknown Object (File)
Sun, Nov 3, 5:04 PM
Unknown Object (File)
Wed, Oct 23, 8:57 PM
Unknown Object (File)
Mon, Oct 21, 6:01 AM
Unknown Object (File)
Oct 14 2024, 10:17 AM
View All Files
Subscribers
brd
imp
whu
Contributor Reviews (src)

Details

Reviewers
whu
Commits
rG80c3eb7bc64b: Hyper-V: hn: add switch to turn on and off RSC
Summary

Currently rsc offloading is enabled by default.
With this new change rsc will be disabled by default.
By using sysctl we can enable and disable it.

Test Plan

Tested on Hyper-V on two bsd12.3 vm with iperf.
Also checked the sysctl to check the rsc pkt count.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schakrabarti_microsoft.com created this revision.Mar 9 2022, 9:09 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 9 2022, 9:09 AM
schakrabarti_microsoft.com requested review of this revision.Mar 9 2022, 9:09 AM
Harbormaster completed remote builds in B44722: Diff 103675.Mar 9 2022, 9:09 AM
whu accepted this revision.Mar 14 2022, 3:54 AM
whu added a subscriber: whu.

Looks good to me. Just a small nit. In the struct hn_softc of if_hnvar.h, I would insert an empty line between line 284 and 285, to make the definition of hn_rsc_ctrl independent from the VF related clause.

This revision is now accepted and ready to land.Mar 14 2022, 3:54 AM
schakrabarti_microsoft.com updated this revision to Diff 103814.Mar 14 2022, 7:04 AM
added rsc ctrl
This revision now requires review to proceed.Mar 14 2022, 7:04 AM
Harbormaster completed remote builds in B44762: Diff 103814.Mar 14 2022, 7:05 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2022, 8:17 AM
Closed by commit rG80c3eb7bc64b: Hyper-V: hn: add switch to turn on and off RSC (authored by whu). · Explain Why
This revision was automatically updated to reflect the committed changes.
whu added a commit: rG80c3eb7bc64b: Hyper-V: hn: add switch to turn on and off RSC.
brd added a subscriber: brd.Apr 19 2022, 7:12 PM

Did this get MFCed?

brd added a comment.Apr 19 2022, 7:21 PM

Sorry, I overlooked the stable/13 commit, but I do not see it in stable/12..

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
netvsc/
1 line
9 lines
30 lines
5 lines

Diff 103865

View Options

sys/dev/hyperv/netvsc/hn_rndis.h

Loading...
View Options

sys/dev/hyperv/netvsc/hn_rndis.c

Loading...
View Options

sys/dev/hyperv/netvsc/if_hn.c

Loading...
View Options

sys/dev/hyperv/netvsc/if_hnvar.h

Loading...