Page MenuHomeFreeBSD
Differential D34441

amd64: Call clock_init() after finishidentcpu()
AbandonedPublic
Actions

Authored by khng on Mar 4 2022, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 11 2024, 6:23 PM
Unknown Object (File)
Sep 17 2024, 7:33 PM
Unknown Object (File)
Sep 5 2024, 10:19 PM
Unknown Object (File)
Aug 25 2024, 6:05 PM
Unknown Object (File)
Aug 22 2024, 2:18 AM
Unknown Object (File)
Aug 16 2024, 9:13 PM
Unknown Object (File)
Aug 8 2024, 4:42 AM
Unknown Object (File)
Jun 28 2024, 12:30 PM
View All 31 Files
Subscribers
imp

Details

Reviewers
markj
Summary

In a subsequent commit clock_init() will attempt to determine the TSC
frequency, and this requires that CPU identification is finalized.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44656
Build 41544: arc lint + arc unit

Event Timeline

khng created this revision.Mar 4 2022, 5:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 4 2022, 5:08 PM
khng requested review of this revision.Mar 4 2022, 5:08 PM
Harbormaster completed remote builds in B44656: Diff 103495.Mar 4 2022, 5:08 PM
markj accepted this revision.Mar 4 2022, 6:34 PM

In a subsequent commit clock_init() will attempt to determine the TSC frequency, and this requires that CPU identification is finalized.

Need to remove "In a subsequent commit" and change "will attempt" to "attempts".

sys/amd64/amd64/machdep.c
1456

A more conservative approach is to move the clock_init() call instead, but ok.

This revision is now accepted and ready to land.Mar 4 2022, 6:34 PM
khng abandoned this revision.Mar 4 2022, 6:41 PM

Superseded by https://reviews.freebsd.org/D34444.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
3 lines

Diff 103495

View Options

sys/amd64/amd64/machdep.c

Loading...