bcm5974: fix endian conversion signedness bug

[val_packett.cool]

Summary

This fixes wrong coordinates resulting in weird behavior.

This was correct in the wsp driver originally.

[val_packett.cool]

remove junk

[wulf]

sys/dev/hid/bcm5974.c

698

Don't modify input report. It can be exported via hidraw latter.

May be something like this will help?

#define WSP_LE2H(x) ((int32_t)(int16_t)le16toh(x))

With changing type of members of struct tp_finger to uint16_t

Or do sign extension with shifts

[val_packett.cool]

switch to macro

[wulf]

Ouch. Actually, the macro should be named as BCM5974_LE2H rather than WSP_LE2H to follow style. I'll handle that.