LinuxKPI: return an address string in pci_name

[val_packett.cool]

Summary

amdgpu's virtual display feature uses pci_name to match a module parameter string, and the documentation shows an example of 0000:26:00.0 for the name.
In our case the name was just drmn, which is silly and not actually unique across devices. Let's generate the expected string.

---

Related to: https://github.com/freebsd/drm-kmod/issues/134
Sponsored by: https://www.patreon.com/valpackett

[val_packett.cool]

contrib/zlib-ng

1 ↗

(On Diff #102657)

hrm, how did git-arc add this o_0 this was not in the commit

sys/compat/linuxkpi/common/src/linux_pci.c

311

I *think* the first part is the domain but I'm not 100% sure…

[• hselasky]

Looks good.

sys/compat/linuxkpi/common/src/linux_pci.c

310

You don't need the "\" here.

4-space indent after line wrap.

[val_packett.cool]

Fix style

[bz]

I am fine with this; iwlwifi only uses the output as informational in dumping and nowhere else and none of my other drivers I was checking do use it.

I think the only thing to clarify before commit should be the MFC path (or not).

sys/compat/linuxkpi/common/include/linux/pci.h

264

Can we add this to the end or do we need to when doing an MFC? Or is this going to be MFCable at all? x11 ?

sys/compat/linuxkpi/common/src/linux_pci.c

280

Do we want to do the alloc game here or should we just use a static buffer? Because if alloc can fail, then we could still return device_get_desc() above in case path_name is NULL?

[val_packett.cool]

sys/compat/linuxkpi/common/src/linux_pci.c

280

Static sounds better, sure.

[• hselasky]

I think GFP_KERNEL doesn't fail, see the definition.
GFP_ATOMIC can fail.

--HPS

[bz]

sys/compat/linuxkpi/common/src/linux_pci.c

280

Based on hps' feedback, I'd say leave it.

[val_packett.cool]

Fix format (more %02d), move the new field to the end of the struct

[val_packett.cool]

format-patch w/o 9999 context: P538

[val_packett.cool]

Rebased. Ping!

[val_packett.cool]

Rebase after D38222

[bz]

I'll take it and commit it given all other consumers but the one amdgpu one seem to be in my wireless driver tree.