Add model RTS5260 and replace bootverbose by rtsx_trace
ClosedPublic
Actions

Authored by hlh_restart.be on Feb 11 2022, 1:49 PM.

Details

Reviewers

jkim
mav

Group Reviewers

manpages

Commits

rG3e5cd5dfd48c: rtsx: Add RTS5260 support and replace bootverbose with sysctl.
rG577130e56e52: rtsx: Add RTS5260 support and replace bootverbose with sysctl.

Summary

The RTS5260 model has been added

To be less verbose when booting with bootverbose=1,
replace bootverbose by rtsx_trace to debug execution of SD command.

Test Plan

Tested on a Dell XPS 13 9310 laptop.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hlh_restart.be created this revision.Feb 11 2022, 1:49 PM

Herald added a reviewer: manpages. · View Herald TranscriptFeb 11 2022, 1:49 PM

Herald added a subscriber: imp. · View Herald Transcript

hlh_restart.be requested review of this revision.Feb 11 2022, 1:49 PM

Harbormaster completed remote builds in B44410: Diff 102655.Feb 11 2022, 1:49 PM

hlh_restart.be retitled this revision from Add model RTS4260 and replace bootverbose by rtsx_trace to Add model RTS5260 and replace bootverbose by rtsx_trace.Feb 11 2022, 2:07 PM

Manual page addition LGTM.

mav accepted this revision.Feb 13 2022, 6:54 PM

mav added inline comments.

sys/dev/rtsx/rtsx.c
136	It looks not very typical for me to see separate variables for trace and debug, especially since debug also has at least two levels. Usually drivers have a bitmask of different levels in one variable. But as you wish.

This revision is now accepted and ready to land.Feb 13 2022, 6:54 PM

Replace rtsx_debug and rtsx_trace by rtsx_debug_mask

This revision now requires review to proceed.Feb 14 2022, 1:23 PM

Harbormaster completed remote builds in B44434: Diff 102742.Feb 14 2022, 1:23 PM

hlh_restart.be marked an inline comment as done.Feb 14 2022, 1:28 PM

LGTM

This revision is now accepted and ready to land.Feb 14 2022, 8:31 PM

pauamma_gundo.com added inline comments.Feb 15 2022, 3:19 AM

share/man/man4/rtsx.4
113–120	Which version is the manual page for? "This bug is no longer present" looks out of place here. I'd be tempted to remove that altogether unless older, unfixed versions are still around.