Page MenuHomeFreeBSD

bwi: Fix clang 14 warning about possible unaligned access
ClosedPublic

Authored by dim on Feb 7 2022, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 3:49 AM
Unknown Object (File)
Thu, Apr 17, 7:40 PM
Unknown Object (File)
Mon, Apr 14, 7:27 PM
Unknown Object (File)
Mar 19 2025, 6:56 PM
Unknown Object (File)
Feb 1 2025, 11:37 AM
Unknown Object (File)
Jan 26 2025, 12:24 PM
Unknown Object (File)
Jan 24 2025, 5:29 PM
Unknown Object (File)
Jan 21 2025, 3:53 PM
Subscribers
None

Details

Summary

On architectures with strict alignment requirements (e.g. arm), clang 14
warns about a packed struct which encloses a non-packed union:

In file included from sys/dev/bwi/bwimac.c:79:
sys/dev/bwi/if_bwivar.h:308:7: error: field iv_val within 'struct bwi_fw_iv' is less aligned than 'union (unnamed union at sys/dev/bwi/if_bwivar.h:305:2)' and is usually due to 'struct bwi_fw_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access]
        }                       iv_val;
                                ^

It appears to help if you also add __packed to the inner union (i.e.
iv_val). No change to the layout is intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable