Page MenuHomeFreeBSD

dma: use canonical getline() loop
ClosedPublic

Authored by emaste on Feb 3 2022, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 11:49 PM
Unknown Object (File)
Tue, Mar 4, 1:04 PM
Unknown Object (File)
Jan 27 2025, 12:49 AM
Unknown Object (File)
Jan 27 2025, 12:48 AM
Unknown Object (File)
Jan 26 2025, 9:12 AM
Unknown Object (File)
Jan 25 2025, 8:22 AM
Unknown Object (File)
Jan 21 2025, 10:39 PM
Unknown Object (File)
Jan 17 2025, 3:33 PM

Details

Summary

getline() returns -1 on erorr or EOF, so just use that condition instead of feof().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Feb 3 2022, 6:52 PM
emaste created this revision.

I don't know why I went the complicated way in the first place ;)

This revision is now accepted and ready to land.Feb 3 2022, 7:22 PM

explicitly set errno = 0 before loop; getline() leaves it unchanged upon EOF

This revision now requires review to proceed.Feb 4 2022, 5:20 PM

use ferror rather than futzing with errno

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2022, 2:56 AM
This revision was automatically updated to reflect the committed changes.