Page MenuHomeFreeBSD

iwlwifi: Disable -Wformat when building with GCC.
ClosedPublic

Authored by jhb on Feb 2 2022, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 4 2025, 10:46 PM
Unknown Object (File)
Jan 30 2025, 6:41 PM
Unknown Object (File)
Jan 19 2025, 3:30 PM
Unknown Object (File)
Jan 17 2025, 8:49 AM
Unknown Object (File)
Jan 1 2025, 9:55 AM
Unknown Object (File)
Dec 10 2024, 3:02 PM
Unknown Object (File)
Dec 3 2024, 12:12 PM
Unknown Object (File)
Dec 3 2024, 12:11 PM
Subscribers

Details

Summary

GCC's -Wformat complains about NULL format strings passed to
iwl_fw_dbg_collect_trig (though the function handles NULL format
strings). Curious that upstream iwlwifi in Linux is built with GCC
and explicitly opts into this warning via the __printf() attribute.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 2 2022, 8:21 PM

Yeah, on the other hand they seem to have trouble adding extra options to just the driver -- from my reading between lines; who knows...

This revision is now accepted and ready to land.Feb 2 2022, 9:44 PM