Page MenuHomeFreeBSD

pf: Initialize pf_kpool mutexes earlier
ClosedPublic

Authored by markj on Jan 31 2022, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:34 PM
Unknown Object (File)
Mon, Jan 27, 4:50 PM
Unknown Object (File)
Mon, Jan 27, 4:49 PM
Unknown Object (File)
Jan 18 2025, 7:21 AM
Unknown Object (File)
Jan 10 2025, 2:49 AM
Unknown Object (File)
Jan 10 2025, 2:42 AM
Unknown Object (File)
Jan 9 2025, 5:50 PM
Unknown Object (File)
Dec 17 2024, 7:46 PM

Details

Summary

There are some error paths in ioctl handlers that will call
pf_krule_free() before the rule's rpool.mtx field is initialized,
causing a panic with INVARIANTS enabled.

Fix the problem by introducing pf_krule_alloc() and initializing the
mutex there. This does mean that the rule->krule and pool->kpool
conversion functions need to stop zeroing the input structure, but I
don't see a nicer way to handle this except perhaps by guarding the
mtx_destroy() with a mtx_initialized() check.

Constify some related functions while here and add a regression test
based on a syzkaller reproducer.

Reported by: syzbot+77cd12872691d219c158@syzkaller.appspotmail.com

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable