Page MenuHomeFreeBSD

fusefs: Address -Wunused-but-set-variable warnings
ClosedPublic

Authored by markj on Jan 19 2022, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:04 AM
Unknown Object (File)
Tue, Oct 22, 7:46 AM
Unknown Object (File)
Oct 3 2024, 4:49 AM
Unknown Object (File)
Oct 1 2024, 10:19 AM
Unknown Object (File)
Sep 28 2024, 12:33 AM
Unknown Object (File)
Sep 21 2024, 2:43 AM
Unknown Object (File)
Sep 20 2024, 5:08 PM
Unknown Object (File)
Sep 20 2024, 12:16 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/fs/fuse/fuse_io.c
525

The need for this went away with commit 84879e46c2bea842c3ad7b1b8b26aeb81946f5a8.

sys/fs/fuse/fuse_node.c
454

I'm not sure if this is an actual bug, though invalidating more than necessary probably isn't a correctness issue.

asomers added inline comments.
sys/fs/fuse/fuse_node.c
454

It's deliberate. If we get here, that means the FUSE server changed the file's size even though we had it cached. If it changed the size, then it probably changed other stuff too. That's why it's best to invalidate the cache for the whole file.

This revision now requires changes to proceed.Jan 19 2022, 11:15 PM
This revision is now accepted and ready to land.Jan 20 2022, 12:07 AM