Page MenuHomeFreeBSD

xen/netfront: deal with mbuf data crossing a page boundary
ClosedPublic

Authored by royger on Jan 13 2022, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:35 AM
Unknown Object (File)
Fri, Nov 1, 5:59 PM
Unknown Object (File)
Thu, Oct 17, 4:48 AM
Unknown Object (File)
Wed, Oct 16, 10:08 PM
Unknown Object (File)
Mon, Oct 14, 6:20 PM
Unknown Object (File)
Mon, Oct 14, 2:02 AM
Unknown Object (File)
Sun, Oct 13, 12:42 AM
Unknown Object (File)
Sat, Oct 12, 7:35 PM

Details

Summary

There's been a report recently of mbufs with data that crosses a page
boundary. It seems those mbufs are generated by the iSCSI target
system:

https://lists.xenproject.org/archives/html/xen-devel/2021-12/msg01581.html

In order to handle those mbufs correctly on netfront use the bus_dma
interface and explicitly request that segments must not cross a page
boundary. No other requirements are necessary, so it's expected that
bus_dma won't need to bounce the data and hence it shouldn't
introduce a too big performance penalty.

Using bus_dma requires some changes to netfront, mainly in order to
accommodate for the fact that now ring slots no longer have a 1:1
match with mbufs, as a single mbuf can use two ring slots if the data
buffer crosses a page boundary. Store the first packet of the mbuf
chain in every ring slot that's used, and use a mbuf tag in order to
store the bus_dma related structures and a refcount to keep track of
the pending slots before the mbuf chain can be freed.

Reported by: G.R.
Tested by: G.R.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable