bsd.compiler.mk: Partially revert workaround to bsd.endian.mk shortcomings
AbandonedPublic
Actions

Authored by imp on Jan 4 2022, 7:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 1:02 AM

	Unknown Object (File)
	Sun, Oct 20, 4:04 AM

	Unknown Object (File)
	Sep 26 2024, 2:53 PM

	Unknown Object (File)
	Sep 17 2024, 6:13 AM

	Unknown Object (File)
	Sep 16 2024, 4:51 PM

	Unknown Object (File)
	Sep 7 2024, 5:13 PM

	Unknown Object (File)
	Sep 4 2024, 11:16 PM

	Unknown Object (File)
	Aug 13 2024, 1:42 PM

Subscribers

Details

Reviewers: None

Summary

cef65082ae12 introduced a special case for enabling debug
symbols. Simplify the special case a little to still include the test
for FreeBSD and little endian, but eliminate the test for is
defined. bsd.endian.mk will now always define TARGET_ENDIAN regardless
of OS. Simplify the comments a little as well.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43704
Build 40592: arc lint + arc unit

Event Timeline

imp created this revision.Jan 4 2022, 7:51 PM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJan 4 2022, 7:51 PM

Harbormaster completed remote builds in B43704: Diff 100937.Jan 4 2022, 7:51 PM

imp requested review of this revision.Jan 4 2022, 7:51 PM

emaste added a subscriber: jrtc27.Jan 4 2022, 7:57 PM

why would we avoid this on non-FreeBSD hosts?

jrtc27 added inline comments.Jan 4 2022, 8:06 PM

share/mk/bsd.compiler.mk
242	This means you never get compressed debug info when cross-compiling even for the target FreeBSD binaries, and is why I wrote it the way I did before.

Just dropping this... with the other changes, the comment is fine as is.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.compiler.mk

10 lines

Diff 100937

View Options

bsd.compiler.mk: Partially revert workaround to bsd.endian.mk shortcomingsAbandonedPublicActions