Page MenuHomeFreeBSD
Differential D33649

dt_unring_buf: set dtbd_oldest to the start of the first record
ClosedPublic
Actions

Authored by avg on Dec 24 2021, 10:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 6:11 AM
Unknown Object (File)
Fri, Mar 7, 2:25 AM
Unknown Object (File)
Tue, Mar 4, 8:41 PM
Unknown Object (File)
Sun, Mar 2, 12:51 PM
Unknown Object (File)
Feb 22 2025, 12:17 PM
Unknown Object (File)
Feb 9 2025, 6:16 AM
Unknown Object (File)
Feb 7 2025, 10:46 PM
Unknown Object (File)
Feb 4 2025, 5:13 PM
View All 71 Files
Subscribers
imp

Details

Reviewers
markj
tsoome
gnn
Group Reviewers
DTrace
Commits
rG256c8c5df2a4: dt_unring_buf: set dtbd_oldest to the start of the first record
Summary

It was set to the start of the buffer and that can be different from the
start of teh first record because of a misalignment.

This change follows the example of dt_realloc_buf().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg created this revision.Dec 24 2021, 10:51 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 24 2021, 10:51 AM
avg requested review of this revision.Dec 24 2021, 10:51 AM
Harbormaster completed remote builds in B43579: Diff 100534.Dec 24 2021, 10:51 AM
avg added a reviewer: DTrace.Dec 24 2021, 10:51 AM
tsoome accepted this revision.Dec 24 2021, 10:57 AM

Good catch.

This revision is now accepted and ready to land.Dec 24 2021, 10:57 AM
avg added a comment.Dec 24 2021, 11:03 AM

Thank you, Toomas.
Could you please run this change by illumos folks as well?
It seems that my emails to developer@lists.illumos.org are not reaching the list.

tsoome added a comment.Dec 24 2021, 11:05 AM

Sure, I was just starting the pickup, if you could mail me git format-patch output, it would be great (So I would get the author and date correct).

markj accepted this revision as: markj.Dec 29 2021, 2:01 PM
Closed by commit rG256c8c5df2a4: dt_unring_buf: set dtbd_oldest to the start of the first record (authored by avg). · Explain WhyJan 11 2022, 1:51 PM
This revision was automatically updated to reflect the committed changes.
avg added a commit: rG256c8c5df2a4: dt_unring_buf: set dtbd_oldest to the start of the first record.
Herald added a reviewer: gnn. · View Herald TranscriptJan 11 2022, 1:51 PM

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
lib/
libdtrace/
common/
2 lines

Diff 101287

View Options

cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c

Loading...