Page MenuHomeFreeBSD

dtrace: Disable getf() as it is broken on FreeBSD.
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Dec 10 2021, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 30 2024, 5:37 AM
Unknown Object (File)
Nov 16 2024, 7:52 AM
Unknown Object (File)
Oct 23 2024, 4:20 PM
Unknown Object (File)
Oct 22 2024, 6:17 PM
Unknown Object (File)
Oct 20 2024, 6:14 PM
Unknown Object (File)
Oct 18 2024, 2:07 AM
Unknown Object (File)
Oct 3 2024, 12:26 AM
Unknown Object (File)
Oct 3 2024, 12:26 AM
Subscribers

Details

Summary

getf() on FreeBSD calls _sx_slock(), _sx_sunlock() and fget_locked().
Furthermore, it does not set the per-core fault flag, meaning it
usually ends up in a double fault panic once getf() does get called,
especially from fbt.

Reviewing the DTrace Toolkit + a number of other scripts scattered
around FreeBSD, I have not been able to find one use of getf(). Given
how broken the implementation currently is, we disable it until it
can be implemented properly.

Also comment out a test in aggs/tst.subr.d for getf().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable