ssh: retire client-side VersionAddendum
ClosedPublic
Actions

Authored by emaste on Nov 10 2021, 5:27 PM.

Details

Reviewers

des
bdrewery
kevans
gordon
glebius

Commits

rGbffe60ead024: ssh: retire client VersionAddendum

Summary

FreeBSD introduced VersionAddendum for the server as a local change in 2001 in R10:933ca70f8f888b7fc1b06213198ba15ca346aeca and extended it to the client in R10:9e2cbe04ff4fa7b48a5deb3469b95314b12040cb.

Upstream adopted VersionAddendum for the server only, in

commit 23528816dc10165b3bc009f2ab5fdf1653db418c
Author: Damien Miller <djm@mindrot.org>
Date:   Sun Apr 22 11:24:43 2012 +1000

       - djm@cvs.openbsd.org 2012/04/12 02:42:32
         [servconf.c servconf.h sshd.c sshd_config sshd_config.5]
         VersionAddendum option to allow server operators to append some arbitrary
         text to the SSH-... banner; ok deraadt@ "don't care" markus@

IMO the argument for supporting this in the client is not nearly as strong as in the server, and this reduces local diffs that we have to carry.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 10 2021, 5:27 PM

emaste created this revision.

emaste added reviewers: kevans, gordon.Apr 15 2022, 11:21 PM

LGTM.

This revision is now accepted and ready to land.Apr 16 2022, 3:35 AM

emaste mentioned this in D29953: ssh, sshd: Add the VersionAddendum configuration variable.Apr 17 2022, 7:18 PM

Removing it from ssh_config has the additional benefit, that local changes in /etc (at the end of the file) doesn't create merge conflicts on updates due to the change of VersionAddendum.

glebius accepted this revision.May 18 2022, 9:11 PM

Closed by commit rGbffe60ead024: ssh: retire client VersionAddendum (authored by emaste). · Explain WhyAug 19 2022, 2:40 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGbffe60ead024: ssh: retire client VersionAddendum.

Herald added a subscriber: imp. · View Herald TranscriptAug 19 2022, 2:40 PM