Page MenuHomeFreeBSD
Differential D32808

ssh: Move common Make boilerplate to new ssh.mk
ClosedPublic
Actions

Authored by emaste on Nov 2 2021, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 8:30 PM
Unknown Object (File)
Sun, Nov 10, 8:15 PM
Unknown Object (File)
Sun, Nov 10, 3:30 PM
Unknown Object (File)
Sat, Oct 26, 7:42 AM
Unknown Object (File)
Sun, Oct 20, 6:07 AM
Unknown Object (File)
Oct 11 2024, 9:19 AM
Unknown Object (File)
Oct 10 2024, 7:09 AM
Unknown Object (File)
Oct 5 2024, 4:09 AM
View All Files
Subscribers
imp

Details

Reviewers
delphij
des
kevans
Commits
rG3687d52b52f6: ssh: move common Makefile boilerplate to a new ssh.mk
rGa0880129a545: ssh: move common Makefile boilerplate to a new ssh.mk
rG9d63429fa163: ssh: move common Makefile boilerplate to a new ssh.mk
Summary

Avoid repeating -I${SSHDIR} and ssh_namespace.h in each ssh-related Makefile.

Proposed in advance of D32509

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 2 2021, 6:50 PM
emaste created this revision.
emaste mentioned this in D32509: ssh: enable FIDO/U2F keys.Nov 2 2021, 7:02 PM
emaste updated this revision to Diff 97887.Nov 2 2021, 8:06 PM

Actually add ssh.mk

emaste added a comment.Nov 2 2021, 11:07 PM

CI build run here: https://cirrus-ci.com/build/5376523071913984

emaste updated this revision to Diff 97901.Nov 3 2021, 12:55 AM

Use ${SRCTOP} for .includes too

emaste added a reviewer: kevans.Nov 3 2021, 12:55 AM
kevans accepted this revision.Nov 3 2021, 10:43 PM
This revision is now accepted and ready to land.Nov 3 2021, 10:43 PM
Closed by commit rG9d63429fa163: ssh: move common Makefile boilerplate to a new ssh.mk (authored by emaste). · Explain WhyNov 3 2021, 11:38 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG9d63429fa163: ssh: move common Makefile boilerplate to a new ssh.mk.
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2021, 11:38 PM
emaste added a commit: rGa0880129a545: ssh: move common Makefile boilerplate to a new ssh.mk.Nov 8 2021, 11:44 PM
emaste added a commit: rG3687d52b52f6: ssh: move common Makefile boilerplate to a new ssh.mk.Nov 9 2021, 12:25 AM

Revision Contents
Changeset List

PathSize
secure/
6 lines
lib/
libssh/
4 lines
libexec/
sftp-server/
3 lines
ssh-keysign/
3 lines
ssh-pkcs11-helper/
3 lines
6 lines
usr.bin/
scp/
3 lines
sftp/
3 lines
ssh-add/
3 lines
ssh-agent/
3 lines
ssh-keygen/
3 lines
ssh-keyscan/
3 lines
ssh/
4 lines
usr.sbin/
sshd/
3 lines

Diff 97988

View Options

secure/Makefile.inc

Loading...
View Options

secure/lib/libssh/Makefile

Loading...
View Options

secure/libexec/sftp-server/Makefile

Loading...
View Options

secure/libexec/ssh-keysign/Makefile

Loading...
View Options

secure/libexec/ssh-pkcs11-helper/Makefile

Loading...
View Options

secure/ssh.mk

Loading...
View Options

secure/usr.bin/scp/Makefile

Loading...
View Options

secure/usr.bin/sftp/Makefile

Loading...
View Options

secure/usr.bin/ssh-add/Makefile

Loading...
View Options

secure/usr.bin/ssh-agent/Makefile

Loading...
View Options

secure/usr.bin/ssh-keygen/Makefile

Loading...
View Options

secure/usr.bin/ssh-keyscan/Makefile

Loading...
View Options

secure/usr.bin/ssh/Makefile

Loading...
View Options

secure/usr.sbin/sshd/Makefile

Loading...