Page MenuHomeFreeBSD
Differential D32737

Update OpenCores i2c driver for SiFive Unmatched.
ClosedPublic
Actions

Authored by skibo on Oct 29 2021, 5:44 PM.
Tags
None
Referenced Files
F108610058: D32737.id.diff
Sun, Jan 26, 8:56 PM
F108595630: D32737.id97754.diff
Sun, Jan 26, 6:28 PM
F108595518: D32737.id97679.diff
Sun, Jan 26, 6:27 PM
Unknown Object (File)
Fri, Jan 24, 6:53 PM
Unknown Object (File)
Thu, Jan 23, 10:37 PM
Unknown Object (File)
Thu, Jan 9, 1:21 PM
Unknown Object (File)
Tue, Jan 7, 1:07 AM
Unknown Object (File)
Mon, Dec 30, 1:25 AM
View All 74 Files
Subscribers
emaste
imp
jrtc27
philip
Contributor Reviews (src)

Details

Reviewers
philip
Group Reviewers
riscv
Commits
rG99443830fa7c: iicoc: support building as a module
rG2a36909a94be: iicoc: fix repeated start
rGe528757ca6a9: iicoc: add support for SiFive HiFive Unmatched
Summary
  • Add compatibility strings for Unmatched.
  • Add support for building driver as a module.
  • Fix repeated start.
Test Plan

Testing on a SiFive Unmatched.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

skibo created this revision.Oct 29 2021, 5:44 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptOct 29 2021, 5:44 PM
skibo requested review of this revision.Oct 29 2021, 5:44 PM
Harbormaster completed remote builds in B42438: Diff 97679.Oct 29 2021, 5:44 PM
emaste added a subscriber: emaste.Oct 29 2021, 6:17 PM
lwhsu added a reviewer: riscv.Oct 30 2021, 3:14 PM
jrtc27 added a subscriber: jrtc27.Oct 30 2021, 3:20 PM
jrtc27 added inline comments.
sys/dev/iicbus/iicoc.c
152 ↗(On Diff #97679)

Use bool

sys/dev/iicbus/iicoc_fdt.c
59

sifive,i2c0? Until devmatch is able to see secondary compatible strings in the device tree, the SoC-specific compats need to be here if you want the module to be auto-loaded (though maybe this will want to just be compiled into the GENERIC kernel?), but we should still have the generic one too.

sys/modules/i2c/controllers/Makefile
8 ↗(On Diff #97679)

Does this need to be limited to RISC-V? The IP isn't tied to a specific core, unlike imcsmb which is Intel's.

sys/modules/i2c/controllers/iicoc/Makefile
1 ↗(On Diff #97679)

I don't think we're adding this for new files?

skibo updated this revision to Diff 97754.Oct 31 2021, 12:42 AM
  • Address review feed-back on iicoc driver.
Harbormaster completed remote builds in B42468: Diff 97754.Oct 31 2021, 12:43 AM
skibo marked 4 inline comments as done.Oct 31 2021, 2:34 AM
skibo added inline comments.
sys/dev/iicbus/iicoc_fdt.c
59

I was on the fence between putting this in GENERIC or creating a module. But now I'm leaning towards putting it in GENERIC. I would also be inclined to drop the module if we did that. What do you think?

sys/modules/i2c/controllers/Makefile
8 ↗(On Diff #97679)

The core is definitely not riscv specific but I thought it would save resources to only build it for riscv. If it shows up in other architectures, we can change it later.

philip accepted this revision.Oct 31 2021, 10:51 AM
philip added a subscriber: philip.

Looks good to me. Thanks!

I think this is fine in GENERIC. I would prefer this to a module.

This revision is now accepted and ready to land.Oct 31 2021, 10:51 AM
Closed by commit rGe528757ca6a9: iicoc: add support for SiFive HiFive Unmatched (authored by skibo, committed by philip). · Explain WhyNov 1 2021, 5:09 AM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rGe528757ca6a9: iicoc: add support for SiFive HiFive Unmatched.
philip added a commit: rG2a36909a94be: iicoc: fix repeated start.
philip added a commit: rG99443830fa7c: iicoc: support building as a module.

Revision Contents
Changeset List

PathSize
sys/
dev/
iicbus/
3 lines

Diff 97784

View Options

sys/dev/iicbus/iicoc_fdt.c

Loading...