Page MenuHomeFreeBSD

Further refine the ExpDataSN checks for SCSI Response PDUs.
ClosedPublic

Authored by jhb on Oct 25 2021, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 2:27 PM
Unknown Object (File)
Sat, Oct 26, 5:43 PM
Unknown Object (File)
Sep 27 2024, 4:41 PM
Unknown Object (File)
Sep 27 2024, 10:17 AM
Unknown Object (File)
Sep 19 2024, 3:31 PM
Unknown Object (File)
Sep 17 2024, 2:48 AM
Unknown Object (File)
Sep 16 2024, 8:16 PM
Unknown Object (File)
Sep 16 2024, 12:58 AM
Subscribers

Details

Summary

According to 11.4.8 in RFC 7143, ExpDataSN MUST be 0 if the response
code is not Command Completed, but we were requiring it to always be
the count of DataIn PDUs regardless of the response code.

In addition, at least one target (OCI Oracle iSCSI block device)
returns an ExpDataSN of 0 when returning a valid completion with an
error status (Check Condition) in response to a SCSI Inquiry. As a
workaround for this target, only warn without resetting the connection
for a 0 ExpDataSN for responses with a non-zero error status.

PR: 259152
Reported by: dch
Fixes: 4f0f5bf99591 iscsi: Validate DataSN values in Data-In PDUs in the initiator.
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable