Fix some NewReno handlers in case of being called from other CC modules
ClosedPublic
Actions

Authored by tuexen on Oct 25 2021, 8:30 PM.

Details

Reviewers

rrs
rscheff

Group Reviewers

transport

Commits

rGb15b0535968e: tcp: allow new reno functions to be called from other CC modules

Summary

Some NewReno functions use the internal data, but are also called from other CC modules. Ensure that in this case, the internal data is not accessed.

This should fix:

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Oct 25 2021, 8:30 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 25 2021, 8:30 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Oct 25 2021, 8:30 PM

tuexen retitled this revision from Fix some NewReno handlers in case of called from other CC modules to Fix some NewReno handlers in case of being called from other CC modules.

rrs accepted this revision.Oct 25 2021, 8:37 PM

This revision is now accepted and ready to land.Oct 25 2021, 8:37 PM

Closed by commit rGb15b0535968e: tcp: allow new reno functions to be called from other CC modules (authored by tuexen). · Explain WhyOct 25 2021, 8:55 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGb15b0535968e: tcp: allow new reno functions to be called from other CC modules.

Overall I think this is a good fix for an ugly problem. I.e. that other
CC algo's use newreno. I think we should re-look at this and have the
"reused" functions put into the kernel as just non-static functions that
can be used by CC modules. Pass in beta etc...

sys/netinet/cc/cc_newreno.c
405	nit double ;; on end

Revision Contents
Changeset List

Path

Size

sys/

netinet/

cc/

cc_newreno.c

47 lines

Diff 97438

View Options

sys/netinet/cc/cc_newreno.c

Fix some NewReno handlers in case of being called from other CC modulesClosedPublicActions