Page MenuHomeFreeBSD
Differential D32647

LinuxKPI: add bcd.h
ClosedPublic
Actions

Authored by bz on Oct 25 2021, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 7:37 PM
Unknown Object (File)
Tue, Oct 29, 6:57 PM
Unknown Object (File)
Tue, Oct 29, 5:55 PM
Unknown Object (File)
Mon, Oct 14, 5:55 AM
Unknown Object (File)
Sun, Oct 13, 2:04 AM
Unknown Object (File)
Sep 21 2024, 3:54 AM
Unknown Object (File)
Sep 19 2024, 3:05 PM
Unknown Object (File)
Sep 18 2024, 10:06 PM
View All 63 Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
• hselasky
Group Reviewers
linuxkpi
Commits
rG548ada00e54a: LinuxKPI: add bcd.h
Summary

Add bcd2bin() as linuxkpi_bcd2bin(). Libkern does provide a bcd2bin()
which cannot be used leaving us with a conflict (see comment in file).
Fortunately this is only seen in one driver so far and it seems easier
to drop this in and change a single line in the driver than to add this
inline in the driver.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Oct 25 2021, 6:20 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptOct 25 2021, 6:20 PM
bz requested review of this revision.Oct 25 2021, 6:20 PM
Harbormaster completed remote builds in B42350: Diff 97422.Oct 25 2021, 6:20 PM
• hselasky added a subscriber: • hselasky.Oct 25 2021, 6:27 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/bcd.h
51

Use function macros here. (Style)

bz updated this revision to Diff 97423.Oct 25 2021, 6:31 PM

Use function macros in #if 0 block for better style.

Harbormaster completed remote builds in B42351: Diff 97423.Oct 25 2021, 6:31 PM
• hselasky added inline comments.Oct 25 2021, 6:31 PM
sys/compat/linuxkpi/common/include/linux/bcd.h
42

spelling: dirvers

bz updated this revision to Diff 97424.Oct 25 2021, 6:32 PM

and try to spell drivers more like it should be written.

Harbormaster completed remote builds in B42352: Diff 97424.Oct 25 2021, 6:32 PM
• hselasky accepted this revision.Oct 25 2021, 6:33 PM

Looks good.

This revision is now accepted and ready to land.Oct 25 2021, 6:33 PM
Closed by commit rG548ada00e54a: LinuxKPI: add bcd.h (authored by bz). · Explain WhyOct 25 2021, 8:23 PM
This revision was automatically updated to reflect the committed changes.
bz marked 2 inline comments as done.
bz added a commit: rG548ada00e54a: LinuxKPI: add bcd.h.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
53 lines

Diff 97433

View Options

sys/compat/linuxkpi/common/include/linux/bcd.h

Loading...