Page MenuHomeFreeBSD
Differential D32305

cam(4): Limit search for disks in SES enclosure by single bus
ClosedPublic
Actions

Authored by mav on Oct 5 2021, 2:26 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Sep 27, 3:14 PM
Unknown Object (File)
Fri, Sep 27, 3:12 PM
Unknown Object (File)
Mon, Sep 23, 11:30 PM
Unknown Object (File)
Mon, Sep 23, 7:04 PM
Unknown Object (File)
Mon, Sep 23, 4:45 PM
Unknown Object (File)
Mon, Sep 23, 1:32 AM
Unknown Object (File)
Sat, Sep 21, 6:07 AM
Unknown Object (File)
Mon, Sep 16, 6:47 PM
View All 73 Files
Subscribers
None

Details

Reviewers
ken
gibbs
imp
Group Reviewers
cam
Commits
rG7e321b97917d: cam(4): Limit search for disks in SES enclosure by single bus
rG730ea72c706e: cam(4): Limit search for disks in SES enclosure by single bus
Summary

At least for SAS we only support now disks are typically connected to the same bus as the enclosure. Limiting the search scope makes it faster on systems with multiple buses and thousands of disks.

Test Plan

Works best in combination with https://reviews.freebsd.org/D32304.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mav requested review of this revision.Oct 5 2021, 2:26 AM
mav created this revision.
mav edited the summary of this revision. (Show Details)
mav added a reviewer: imp.Oct 5 2021, 3:40 AM
imp added inline comments.Oct 5 2021, 3:52 AM
sys/cam/scsi/scsi_enc_ses.c
898

This is going in after your change from MATCH_NONE == 0 to MATCH_ANY == 0?
If so, then it's good.

mav added inline comments.Oct 5 2021, 4:23 AM
sys/cam/scsi/scsi_enc_ses.c
898

It is. Though not sure why have you mentioned MATCH_ANY == 0 part, not the optimization in the same review.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2021, 7:04 PM
Closed by commit rG730ea72c706e: cam(4): Limit search for disks in SES enclosure by single bus (authored by mav). · Explain Why
This revision was automatically updated to reflect the committed changes.
mav added a commit: rG730ea72c706e: cam(4): Limit search for disks in SES enclosure by single bus.
mav added a commit: rG7e321b97917d: cam(4): Limit search for disks in SES enclosure by single bus.Oct 19 2021, 3:07 PM

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
8 lines

Diff 96298

View Options

sys/cam/scsi/scsi_enc_ses.c

Loading...