Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 3 2024, 7:31 PM
Unknown Object (File)
Oct 3 2024, 3:10 PM
Unknown Object (File)
Oct 3 2024, 11:41 AM
Unknown Object (File)
Oct 1 2024, 9:30 AM
Unknown Object (File)
Oct 1 2024, 7:18 AM
Unknown Object (File)
Sep 25 2024, 3:45 AM
Unknown Object (File)
Sep 19 2024, 3:43 PM
Unknown Object (File)
Sep 18 2024, 2:22 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable