Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 3:03 PM
Unknown Object (File)
Wed, Mar 12, 11:15 PM
Unknown Object (File)
Thu, Mar 6, 3:32 PM
Unknown Object (File)
Feb 23 2025, 11:54 AM
Unknown Object (File)
Feb 2 2025, 2:01 AM
Unknown Object (File)
Jan 20 2025, 9:41 AM
Unknown Object (File)
Jan 12 2025, 9:30 AM
Unknown Object (File)
Jan 12 2025, 5:37 AM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable