Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 3:45 AM
Unknown Object (File)
Thu, Sep 19, 3:43 PM
Unknown Object (File)
Wed, Sep 18, 2:22 PM
Unknown Object (File)
Tue, Sep 17, 4:36 AM
Unknown Object (File)
Fri, Sep 13, 5:59 PM
Unknown Object (File)
Fri, Sep 13, 5:45 PM
Unknown Object (File)
Mon, Sep 9, 1:11 PM
Unknown Object (File)
Thu, Sep 5, 9:58 AM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable