Page MenuHomeFreeBSD
Differential D32054

Mk/Uses/go.mk: Fix gomod-clean target when lang/go is not installed
ClosedPublic
Actions

Authored by ygy on Sep 22 2021, 2:58 AM.
Tags
None
Referenced Files
F102578557: D32054.diff
Thu, Nov 14, 7:37 AM
Unknown Object (File)
Thu, Nov 7, 4:18 PM
Unknown Object (File)
Wed, Nov 6, 7:01 PM
Unknown Object (File)
Tue, Nov 5, 10:48 AM
Unknown Object (File)
Thu, Oct 31, 5:37 PM
Unknown Object (File)
Thu, Oct 17, 11:43 AM
Unknown Object (File)
Thu, Oct 17, 2:30 AM
Unknown Object (File)
Oct 14 2024, 11:55 PM
View All 88 Files
Subscribers
None

Details

Reviewers
dmgk
Group Reviewers
portmgr
Commits
R11:3271400a5e29: Mk/Uses/go.mk: fix gomod-clean target when lang/go is not installed
R11:f76516f11076: Mk/Uses/go.mk: fix gomod-clean target when lang/go is not installed
Summary

Mk/Uses/go.mk breaks make distclean target if go is not installed.

PR: 258359
Reported by: Rin Morningstar <ports.maintainer@evilphi.com>

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ygy requested review of this revision.Sep 22 2021, 2:58 AM
ygy created this revision.
dmgk accepted this revision.Sep 22 2021, 4:04 PM

LGTM although maybe it would be good to provide some kind of feedback on why make distclean was skipped and advise to install go to make it work.

This revision is now accepted and ready to land.Sep 22 2021, 4:04 PM
ygy added a comment.Nov 3 2021, 12:21 AM
In D32054#723427, @dmgk wrote:

LGTM although maybe it would be good to provide some kind of feedback on why make distclean was skipped and advise to install go to make it work.

Yes, that would be helpful. I do think it should remain informational rather than an error.

ygy updated this revision to Diff 97900.Nov 3 2021, 12:25 AM
ygy edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Nov 3 2021, 12:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2021, 1:29 AM
Closed by commit R11:f76516f11076: Mk/Uses/go.mk: fix gomod-clean target when lang/go is not installed (authored by ygy). · Explain Why
This revision was automatically updated to reflect the committed changes.
ygy added a commit: R11:f76516f11076: Mk/Uses/go.mk: fix gomod-clean target when lang/go is not installed.
ygy added a commit: R11:3271400a5e29: Mk/Uses/go.mk: fix gomod-clean target when lang/go is not installed.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
4 lines

Diff 98149

View Options

Mk/Uses/go.mk

Loading...