Page MenuHomeFreeBSD
Differential D32003

readelf: include notes (-n) in --all/-a
ClosedPublic
Actions

Authored by emaste on Sep 17 2021, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 18, 3:51 AM
Unknown Object (File)
Tue, Sep 17, 12:52 AM
Unknown Object (File)
Wed, Sep 4, 11:32 AM
Unknown Object (File)
Tue, Sep 3, 9:45 AM
Unknown Object (File)
Tue, Sep 3, 9:45 AM
Unknown Object (File)
Tue, Sep 3, 9:45 AM
Unknown Object (File)
Tue, Sep 3, 9:45 AM
Unknown Object (File)
Tue, Sep 3, 9:35 AM
View All 67 Files
Subscribers
None

Details

Reviewers
andrew
markj
Commits
rG217324224472: readelf: include notes (-n) and unwind (-u) in --all/-a
rGcd6569d47ce5: readelf: include notes (-n) and unwind (-u) in --all/-a
rGac8994cf5bc5: readelf: include notes (-n) and unwind (-u) in --all/-a
rGf161abf9f2cd: readelf: include notes (-n) and unwind (-u) in --all/-a
Summary
This matches the GNU and LLVM versions of readelf.

Reported by:    andrew
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Sep 17 2021, 12:10 PM
emaste created this revision.
emaste updated this revision to Diff 95287.Sep 17 2021, 1:30 PM
emaste added a reviewer: markj.

Also add unwind

markj accepted this revision.Sep 17 2021, 1:34 PM

-u is undocumented, BTW.

This revision is now accepted and ready to land.Sep 17 2021, 1:34 PM
andrew accepted this revision.Sep 17 2021, 1:35 PM
emaste added a comment.Sep 17 2021, 1:51 PM

-u is undocumented, BTW.

It's also unimplemented :(
-u sets RE_U, but it's never tested and does nothing.
But, if/when it gets implemented it will be picked up in -a as it should.

Closed by commit rGf161abf9f2cd: readelf: include notes (-n) and unwind (-u) in --all/-a (authored by emaste). · Explain WhySep 17 2021, 1:57 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGf161abf9f2cd: readelf: include notes (-n) and unwind (-u) in --all/-a.
emaste mentioned this in rGdeef4b8ce8ba: readelf: document that -u / --unwind is not yet implemented.Sep 17 2021, 2:26 PM
emaste added a commit: rGac8994cf5bc5: readelf: include notes (-n) and unwind (-u) in --all/-a.Sep 24 2021, 12:58 AM
emaste mentioned this in rG04676c953a90: readelf: document that -u / --unwind is not yet implemented.
emaste mentioned this in rG8c495a9f4998: readelf: document that -u / --unwind is not yet implemented.
emaste added a commit: rGcd6569d47ce5: readelf: include notes (-n) and unwind (-u) in --all/-a.
emaste added a commit: rG217324224472: readelf: include notes (-n) and unwind (-u) in --all/-a.Sep 24 2021, 1:02 AM
emaste mentioned this in rG1f9c81f259f3: readelf: document that -u / --unwind is not yet implemented.

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
readelf/
4 lines
2 lines

Diff 95289

View Options

contrib/elftoolchain/readelf/readelf.1

Loading...
View Options

contrib/elftoolchain/readelf/readelf.c

Loading...