Paths

Table of Contentst

Differential D31948

mana: Cast an unused value to void to quiet a warning.
ClosedPublic
Actions

Authored by jhb on Sep 13 2021, 6:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 24 2024, 5:35 AM

	Unknown Object (File)
	Sep 24 2024, 12:21 AM

	Unknown Object (File)
	Sep 17 2024, 9:53 PM

	Unknown Object (File)
	Sep 12 2024, 6:20 AM

	Unknown Object (File)
	Sep 9 2024, 5:56 AM

	Unknown Object (File)
	Sep 6 2024, 2:42 AM

	Unknown Object (File)
	Sep 5 2024, 7:34 AM

	Unknown Object (File)
	Sep 3 2024, 2:23 AM

View All 41 Files

Subscribers

Details

Reviewers

Commits

rG0def501d143a: mana: Cast an unused value to void to quiet a warning.

Summary

This appeases a -Wunused-value warning from GCC 9.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 13 2021, 6:28 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2021, 6:28 PM

jhb requested review of this revision.Sep 13 2021, 6:28 PM

Harbormaster completed remote builds in B41502: Diff 95074.Sep 13 2021, 6:28 PM

Adding an atomic_inc() wrapper might be a cleaner way of fixing this.

imp added inline comments.Sep 13 2021, 7:11 PM

sys/dev/mana/mana_en.c
579	why not just atmoic_inc?

lwhsu added a subscriber: lwhsu.Sep 14 2021, 2:13 AM

jhb added inline comments.Sep 15 2021, 3:57 PM

sys/dev/mana/mana_en.c
579	Because we don't have it yet and would need to add a wrapper in the foo.h compat header that defines atomic_inc_return(). I did suggest it as an alternative though if that would be cleaner.

Thanks for fixing this warning.

This revision is now accepted and ready to land.Sep 16 2021, 4:01 AM

Closed by commit rG0def501d143a: mana: Cast an unused value to void to quiet a warning. (authored by jhb). · Explain WhySep 25 2021, 6:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0def501d143a: mana: Cast an unused value to void to quiet a warning..

Revision Contents
Changeset List

Path

Size

sys/

dev/

mana/

2 lines

Diff 95736

sys/dev/mana/mana_en.c

Loading...