Page MenuHomeFreeBSD

sctp: Fix lock recursion in sctp_swap_inpcb_for_listen()
ClosedPublic

Authored by markj on Sep 8 2021, 3:06 AM.
Tags
None
Referenced Files
F102419860: D31878.diff
Tue, Nov 12, 12:54 AM
Unknown Object (File)
Thu, Oct 24, 11:28 AM
Unknown Object (File)
Thu, Oct 24, 11:28 AM
Unknown Object (File)
Thu, Oct 24, 11:28 AM
Unknown Object (File)
Thu, Oct 24, 11:08 AM
Unknown Object (File)
Tue, Oct 15, 11:23 AM
Unknown Object (File)
Oct 5 2024, 2:29 PM
Unknown Object (File)
Oct 4 2024, 10:46 AM
Subscribers

Details

Summary

After commit bd4a39cc93d9 we now hold the global inp info lock across
the call to sctp_swap_inpcb_for_listen(), which attempts to acquire it
again. Since sctp_swap_inpcb_for_listen()'s sole caller is
sctp_listen(), we can simply change it to not try to acquire the lock.

Fixes: bd4a39cc93d9 ("socket: Properly interlock when transitioning to a listening socket")
Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable