Page MenuHomeFreeBSD
Differential D31775

powerpc64: fix radix on pseries TLB invalidation
ClosedPublic
Actions

Authored by luporl on Sep 1 2021, 6:20 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Nov 7, 3:31 AM
Unknown Object (File)
Fri, Oct 25, 9:03 AM
Unknown Object (File)
Sun, Oct 20, 12:22 AM
Unknown Object (File)
Sat, Oct 19, 8:10 PM
Unknown Object (File)
Fri, Oct 18, 8:54 AM
Unknown Object (File)
Wed, Oct 16, 5:36 AM
Unknown Object (File)
Wed, Oct 16, 5:36 AM
Unknown Object (File)
Tue, Oct 15, 12:47 PM
View All 98 Files
Subscribers
alfredo
bdragon
imp

Details

Reviewers
jhibbits
Commits
rG0ccf063e075a: powerpc64: fix radix on pseries TLB invalidation
rG4f7c436548ea: powerpc64: fix radix on pseries TLB invalidation
Summary

When running in a virtualized environment, TLB invalidations can only
be performed on process scope, as only the hypervisor is allowed to
invalidate a global scope, or else a Program Interrupt is triggered.

Since we are here, also make sure that the register process table
hypercall returns success.

Test Plan

Tested on QEMU with KVM enabled, on a POWER9 machine.
(currently depends on a patched loader version to work, to call CAS and select Radix with GTSE)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

luporl created this revision.Sep 1 2021, 6:20 PM
Herald added subscribers: alfredo, bdragon, imp. · View Herald TranscriptSep 1 2021, 6:20 PM
luporl requested review of this revision.Sep 1 2021, 6:20 PM
Harbormaster completed remote builds in B41317: Diff 94505.Sep 1 2021, 6:20 PM
jhibbits added a comment.Sep 1 2021, 7:31 PM

Glad to see you solve the last piece of this puzzle!

sys/powerpc/aim/mmu_radix.c
761–765

Can TLB_INVAL_SCOPE_* be renumbered to 2/3 instead of 0/1? That would avoid needing to pass the scope as extra.

luporl updated this revision to Diff 94751.Sep 6 2021, 6:16 PM
  • Address reviewer's comments
Harbormaster completed remote builds in B41413: Diff 94751.Sep 6 2021, 6:16 PM
luporl marked an inline comment as done.Sep 6 2021, 6:16 PM
jhibbits accepted this revision.Sep 6 2021, 6:57 PM
This revision is now accepted and ready to land.Sep 6 2021, 6:57 PM
Closed by commit rG4f7c436548ea: powerpc64: fix radix on pseries TLB invalidation (authored by luporl). · Explain WhySep 8 2021, 11:44 AM
This revision was automatically updated to reflect the committed changes.
luporl added a commit: rG4f7c436548ea: powerpc64: fix radix on pseries TLB invalidation.
luporl added a commit: rG0ccf063e075a: powerpc64: fix radix on pseries TLB invalidation.Oct 4 2022, 4:30 PM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
aim/
27 lines

Diff 94882

View Options

sys/powerpc/aim/mmu_radix.c

Loading...